From b8921a5485b3e2de69bd4e01c6c76164f324ad5f Mon Sep 17 00:00:00 2001 From: oxalica Date: Tue, 8 Oct 2024 23:19:04 -0400 Subject: [PATCH] chore(*): remove or update obsolete TODOs --- blah-types/src/identity.rs | 1 - blahd/Cargo.toml | 2 +- blahd/config.example.toml | 3 ++- blahd/src/feed.rs | 1 - blahd/tests/webapi.rs | 3 +-- contrib/module.nix | 2 +- 6 files changed, 5 insertions(+), 7 deletions(-) diff --git a/blah-types/src/identity.rs b/blah-types/src/identity.rs index 659325c..5012c70 100644 --- a/blah-types/src/identity.rs +++ b/blah-types/src/identity.rs @@ -89,7 +89,6 @@ impl UserIdentityDesc { } } -// TODO: JWS or alike? #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] #[serde(tag = "typ", rename = "user_act_key")] pub struct UserActKeyDesc { diff --git a/blahd/Cargo.toml b/blahd/Cargo.toml index a1645a0..3dd72d6 100644 --- a/blahd/Cargo.toml +++ b/blahd/Cargo.toml @@ -12,7 +12,7 @@ anyhow = "1" axum = { version = "0.7", features = ["ws"] } axum-extra = "0.9" clap = { version = "4", features = ["derive"] } -data-encoding = "2" # TODO: Also use it for hex? +data-encoding = "2" ed25519-dalek = "2" futures-util = "0.3" hex = { version = "0.4", features = ["serde"] } diff --git a/blahd/config.example.toml b/blahd/config.example.toml index 631e801..b96691a 100644 --- a/blahd/config.example.toml +++ b/blahd/config.example.toml @@ -24,7 +24,8 @@ address = "localhost:8080" # Use systemd socket activation mechanism to get listener fd from envvars. # See also sd_listen_fds(3) and systemd.socket(5). -# NB. Currently only TCP sockets are supported. UNIX domain socket is TODO. +# NB. Currently only TCP sockets are supported. UNIX domain socket support is +# blocked by axum 0.5, see https://github.com/tokio-rs/axum/pull/2941 #systemd = true [server] diff --git a/blahd/src/feed.rs b/blahd/src/feed.rs index ff91471..35f8d9b 100644 --- a/blahd/src/feed.rs +++ b/blahd/src/feed.rs @@ -176,7 +176,6 @@ impl fmt::Display for AtomFeed { r#" "# )?; } - // TODO: HTML links. for msg in msgs { let content = &msg.msg.signee.payload.rich_text; diff --git a/blahd/tests/webapi.rs b/blahd/tests/webapi.rs index c9d9753..862703e 100644 --- a/blahd/tests/webapi.rs +++ b/blahd/tests/webapi.rs @@ -417,7 +417,7 @@ fn server() -> Server { server_with(db, &CONFIG) } -// TODO: Testing config is hard to build because it does have a `Default` impl. +// TODO: Testing config is hard to build because it lacks a `Default` impl. #[track_caller] fn server_with(db: Database, config: &dyn Fn(u16) -> String) -> Server { // Use std's to avoid async, since we need no name resolution. @@ -1215,7 +1215,6 @@ async fn register_flow(server: Server) { req.server_url = BASE_URL.parse().unwrap(); // Trailing dot in id_url. - // TODO: Rule this out in `IdUrl` parser? register_fast(&req) .await .expect_api_err(StatusCode::FORBIDDEN, "disabled"); diff --git a/contrib/module.nix b/contrib/module.nix index 842a42e..064d80a 100644 --- a/contrib/module.nix +++ b/contrib/module.nix @@ -31,7 +31,7 @@ let settingsType = types.submodule { freeformType = toml.type; - # TODO: Auto-generate these options? Now only required options are documented. + # TODO: Auto-generate these options? options = { }; };