remove(webapi)!: remove auto user creation on joining or creating room

User must be explicitly created forehand using the registration API
(coming soon).

blahd/src/lib.rs

@@ -434,6 +434,23 @@ async fn room_create_peer_chat(
 
     let mut conn = st.db.get();
     let txn = conn.transaction()?;
+    let src_uid = txn
+        .query_row(
+            r"
+            SELECT `uid` FROM `user`
+            WHERE `userkey` = ?
+            ",
+            params![src_user],
+            |row| row.get::<_, i64>(0),
+        )
+        .optional()?
+        .ok_or_else(|| {
+            error_response!(
+                StatusCode::NOT_FOUND,
+                "not_found",
+                "the user does not exist",
+            )
+        })?;
     let tgt_uid = txn
         .query_row(
             r"
@@ -456,29 +473,6 @@ async fn room_create_peer_chat(
                 "peer user does not exist or disallows peer chat",
             )
         })?;
-    let src_uid = txn
-        .query_row(
-            r"
-            SELECT `uid` FROM `user`
-            WHERE `userkey` = ?
-            ",
-            params![src_user],
-            |row| row.get::<_, i64>(0),
-        )
-        .optional()?;
-    let src_uid = match src_uid {
-        Some(uid) => uid,
-        None => {
-            txn.execute(
-                r"
-                INSERT INTO `user` (`userkey`)
-                VALUES (?)
-                ",
-                params![src_user],
-            )?;
-            txn.last_insert_rowid()
-        }
-    };
 
     let (peer1, peer2) = if src_uid <= tgt_uid {
         (src_uid, tgt_uid)
@@ -955,8 +949,25 @@ async fn room_join(
 ) -> Result<(), ApiError> {
     let mut conn = st.db.get();
     let txn = conn.transaction()?;
-    let is_public_joinable = txn
+    let uid = txn
         .query_row(
+            r"
+            SELECT `uid`
+            FROM `user`
+            WHERE `userkey` = ?
+            ",
+            params![user],
+            |row| row.get::<_, i32>(0),
+        )
+        .optional()?
+        .ok_or_else(|| {
+            error_response!(
+                StatusCode::NOT_FOUND,
+                "not_found",
+                "the user does not exist",
+            )
+        })?;
+    txn.query_row(
         r"
         SELECT `attrs`
         FROM `room`
@@ -966,34 +977,24 @@ async fn room_join(
         |row| row.get::<_, RoomAttrs>(0),
     )
     .optional()?
-        .is_some_and(|attrs| attrs.contains(RoomAttrs::PUBLIC_JOINABLE));
+    .filter(|attrs| attrs.contains(RoomAttrs::PUBLIC_JOINABLE))
-    if !is_public_joinable {
+    .ok_or_else(|| {
-        return Err(error_response!(
+        error_response!(
             StatusCode::NOT_FOUND,
             "not_found",
             "the room does not exist or the user is not allowed to join the room",
-        ));
+        )
-    }
+    })?;
 
-    txn.execute(
-        r"
-        INSERT INTO `user` (`userkey`)
-        VALUES (?)
-        ON CONFLICT (`userkey`) DO NOTHING
-        ",
-        params![user],
-    )?;
     let updated = txn.execute(
         r"
         INSERT INTO `room_member` (`rid`, `uid`, `permission`)
-        SELECT :rid, `uid`, :perm
+        SELECT :rid, :uid, :perm
-        FROM `user`
-        WHERE `userkey` = :userkey
         ON CONFLICT (`rid`, `uid`) DO NOTHING
         ",
         named_params! {
            ":rid": rid,
-           ":userkey": user,
+           ":uid": uid,
            ":perm": permission,
         },
     )?;

blahd/tests/webapi.rs

@@ -202,11 +202,22 @@ fn server() -> Server {
 
     let mut conn = Connection::open_in_memory().unwrap();
     Database::maybe_init(&mut conn).unwrap();
-    conn.execute(
+    {
-        "INSERT INTO `user` (`userkey`, `permission`) VALUES (?, ?)",
+        let mut add_user = conn
-        params![*ALICE, ServerPermission::ALL],
+            .prepare(
+                r"
+                INSERT INTO `user` (`userkey`, `permission`)
+                VALUES (?, ?)
+                ",
             )
             .unwrap();
+        for (user, perm) in [
+            (&*ALICE, ServerPermission::ALL),
+            (&BOB, ServerPermission::empty()),
+        ] {
+            add_user.execute(params![user, perm]).unwrap();
+        }
+    }
     let db = Database::from_raw(conn).unwrap();
 
     // Use std's to avoid async, since we need no name resolution.

docs/webapi.yaml

@@ -138,7 +138,9 @@ paths:
                 $ref: '#/components/schemas/ApiError'
 
         404:
-          description: The peer user does not exist or disallows peer chat.
+          description: |
+            The current user does not exists, the peer user does not exist or
+            they disallows peer chat.
           content:
             application/json:
               schema: