From 2eb884766a32bc4fa58f6042147c0d6782df2244 Mon Sep 17 00:00:00 2001
From: oxalica <oxalicc@pm.me>
Date: Tue, 3 Sep 2024 05:38:20 -0400
Subject: [PATCH] Impl room leaving and fix frontend room combobox

---
 blahd/src/main.rs | 106 +++++++++++++++++++++++++++++++++++++---------
 pages/index.html  |   1 +
 pages/main.js     |  41 ++++++++++++++++--
 src/types.rs      |  51 +++++++++++++++-------
 4 files changed, 159 insertions(+), 40 deletions(-)

diff --git a/blahd/src/main.rs b/blahd/src/main.rs
index fc40db1..0a1b3b2 100644
--- a/blahd/src/main.rs
+++ b/blahd/src/main.rs
@@ -12,8 +12,8 @@ use axum::routing::{get, post};
 use axum::{Json, Router};
 use axum_extra::extract::WithRejection;
 use blah::types::{
-    ChatItem, ChatPayload, CreateRoomPayload, MemberPermission, RoomAdminPayload, RoomAttrs,
-    ServerPermission, Signee, UserKey, WithSig,
+    ChatItem, ChatPayload, CreateRoomPayload, MemberPermission, RoomAdminOp, RoomAdminPayload,
+    RoomAttrs, ServerPermission, Signee, UserKey, WithSig,
 };
 use config::Config;
 use ed25519_dalek::SIGNATURE_LENGTH;
@@ -737,7 +737,7 @@ async fn room_admin(
     Path(ruuid): Path<Uuid>,
     SignedJson(op): SignedJson<RoomAdminPayload>,
 ) -> Result<StatusCode, ApiError> {
-    if ruuid != *op.signee.payload.room() {
+    if ruuid != op.signee.payload.room {
         return Err(error_response!(
             StatusCode::BAD_REQUEST,
             "invalid_request",
@@ -745,24 +745,45 @@ async fn room_admin(
         ));
     }
 
-    let RoomAdminPayload::AddMember {
-        permission, user, ..
-    } = op.signee.payload;
-    if user != op.signee.user {
-        return Err(error_response!(
-            StatusCode::NOT_IMPLEMENTED,
-            "not_implemented",
-            "only self-adding is implemented yet",
-        ));
-    }
-    if permission.is_empty() || !MemberPermission::MAX_SELF_ADD.contains(permission) {
-        return Err(error_response!(
-            StatusCode::BAD_REQUEST,
-            "deserialization",
-            "invalid permission",
-        ));
+    match op.signee.payload.op {
+        RoomAdminOp::AddMember { user, permission } => {
+            if user != op.signee.user {
+                return Err(error_response!(
+                    StatusCode::NOT_IMPLEMENTED,
+                    "not_implemented",
+                    "only self-adding is implemented yet",
+                ));
+            }
+            if permission.is_empty() || !MemberPermission::MAX_SELF_ADD.contains(permission) {
+                return Err(error_response!(
+                    StatusCode::BAD_REQUEST,
+                    "deserialization",
+                    "invalid permission",
+                ));
+            }
+            room_join(&st, ruuid, user, permission).await?;
+        }
+        RoomAdminOp::RemoveMember { user } => {
+            if user != op.signee.user {
+                return Err(error_response!(
+                    StatusCode::NOT_IMPLEMENTED,
+                    "not_implemented",
+                    "only self-removing is implemented yet",
+                ));
+            }
+            room_leave(&st, ruuid, user).await?;
+        }
     }
 
+    Ok(StatusCode::NO_CONTENT)
+}
+
+async fn room_join(
+    st: &AppState,
+    ruuid: Uuid,
+    user: UserKey,
+    permission: MemberPermission,
+) -> Result<(), ApiError> {
     let mut conn = st.conn.lock().unwrap();
     let txn = conn.transaction()?;
     let Some(rid) = txn
@@ -811,6 +832,49 @@ async fn room_admin(
         },
     )?;
     txn.commit()?;
-
-    Ok(StatusCode::NO_CONTENT)
+    Ok(())
+}
+
+async fn room_leave(st: &AppState, ruuid: Uuid, user: UserKey) -> Result<(), ApiError> {
+    let mut conn = st.conn.lock().unwrap();
+    let txn = conn.transaction()?;
+
+    let Some((rid, uid)) = txn
+        .query_row(
+            r"
+            SELECT `rid`, `uid`
+            FROM `room_member`
+            JOIN `room` USING (`rid`)
+            JOIN `user` USING (`uid`)
+            WHERE `ruuid` = :ruuid AND
+                `userkey` = :userkey
+            ",
+            named_params! {
+                ":ruuid": ruuid,
+                ":userkey": user,
+            },
+            |row| Ok((row.get::<_, u64>("rid")?, row.get::<_, u64>("uid")?)),
+        )
+        .optional()?
+    else {
+        return Err(error_response!(
+            StatusCode::NOT_FOUND,
+            "not_found",
+            "room does not exists or user is not a room member",
+        ));
+    };
+    txn.execute(
+        r"
+        DELETE FROM `room_member`
+        WHERE `rid` = :rid AND
+            `uid` = :uid
+        ",
+        named_params! {
+            ":rid": rid,
+            ":uid": uid,
+        },
+    )?;
+
+    txn.commit()?;
+    Ok(())
 }
diff --git a/pages/index.html b/pages/index.html
index 7f67c46..b4174f9 100644
--- a/pages/index.html
+++ b/pages/index.html
@@ -71,6 +71,7 @@
         <label for="join-new-room">join public room:</label>
         <select id="join-new-room"></select>
 
+        <button id="leave-room">leave room</select>
         <button id="refresh-rooms">refresh room list</select>
       </div>
       <div>
diff --git a/pages/main.js b/pages/main.js
index 2ace57f..2ea8b4c 100644
--- a/pages/main.js
+++ b/pages/main.js
@@ -2,6 +2,7 @@ const msgFlow = document.querySelector('#msg-flow');
 const userPubkeyDisplay = document.querySelector('#user-pubkey');
 const serverUrlInput = document.querySelector('#server-url');
 const roomsInput = document.querySelector('#rooms');
+const leaveRoomBtn = document.querySelector('#leave-room');
 const joinNewRoomInput = document.querySelector('#join-new-room');
 const chatInput = document.querySelector('#chat');
 const regenKeyBtn = document.querySelector('#regen-key');
@@ -172,6 +173,7 @@ async function genAuthHeader() {
 async function enterRoom(ruuid) {
     log(`loading room: ${ruuid}`);
     curRoom = ruuid;
+    roomsInput.value = ruuid;
 
     genAuthHeader()
     .then(opts => fetch(`${serverUrl}/room/${ruuid}`, opts))
@@ -218,7 +220,7 @@ async function connectServer(newServerUrl) {
 
     log('connecting server');
     wsUrl.protocol = wsUrl.protocol == 'http:' ? 'ws:' : 'wss:';
-    wsUrl.pathname += '/ws';
+    wsUrl.pathname += wsUrl.pathname.endsWith('/') ? 'ws' : '/ws';
     ws = new WebSocket(wsUrl);
     ws.onopen = async (_) => {
         const auth = await signData({ typ: 'auth' });
@@ -256,8 +258,14 @@ async function loadRoomList(autoJoin) {
     log('loading room list');
 
     async function loadInto(targetEl, filter) {
+        const emptyEl = document.createElement('option');
+        emptyEl.value = '';
+        emptyEl.innerText = '-';
+        emptyEl.disabled = true;
+        targetEl.replaceChildren(emptyEl);
+        targetEl.value = '';
+
         try {
-            targetEl.replaceChildren();
             const resp = await fetch(`${serverUrl}/room?filter=${filter}`, await genAuthHeader())
             const json = await resp.json()
             if (resp.status !== 200) throw new Error(`status ${resp.status}: ${json.error.message}`);
@@ -274,8 +282,11 @@ async function loadRoomList(autoJoin) {
 
     loadInto(roomsInput, 'joined')
     .then(async (_) => {
-        if (autoJoin && roomsInput.value !== '') {
-            await enterRoom(roomsInput.value);
+        if (autoJoin) {
+            const el = roomsInput.querySelector('option:nth-child(2)');
+            if (el !== null) {
+                await enterRoom(el.value);
+            }
         }
     });
 
@@ -303,6 +314,25 @@ async function joinRoom(ruuid) {
     }
 }
 
+async function leaveRoom() {
+    try {
+        leaveRoomBtn.disabled = true;
+        await signAndPost(`${serverUrl}/room/${curRoom}/admin`, {
+            room: curRoom,
+            typ: 'remove_member',
+            user: await getUserPubkey(),
+        });
+        log('left room');
+        await loadRoomList(true);
+    } catch (e) {
+        console.error(e);
+        log(`failed to leave room: ${e}`);
+    } finally {
+        leaveRoomBtn.disabled = false;
+    }
+}
+
+
 async function signAndPost(url, data) {
     const signedPayload = await signData(data);
     const resp = await fetch(url, {
@@ -398,6 +428,9 @@ chatInput.onkeypress = async (e) => {
 regenKeyBtn.onclick = async (_) => {
     await generateKeypair();
 };
+leaveRoomBtn.onclick = async (_) => {
+    await leaveRoom();
+};
 roomsInput.onchange = async (_) => {
     await enterRoom(roomsInput.value);
 };
diff --git a/src/types.rs b/src/types.rs
index 4a4005e..349f9e5 100644
--- a/src/types.rs
+++ b/src/types.rs
@@ -326,23 +326,25 @@ pub struct RoomMember {
 #[serde(tag = "typ", rename = "auth")]
 pub struct AuthPayload {}
 
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(deny_unknown_fields, tag = "typ", rename_all = "snake_case")]
-pub enum RoomAdminPayload {
-    AddMember {
-        permission: MemberPermission,
-        room: Uuid,
-        user: UserKey,
-    },
-    // TODO: CRUD
+#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[serde(tag = "typ", rename_all = "snake_case")]
+pub struct RoomAdminPayload {
+    pub room: Uuid,
+    #[serde(flatten)]
+    pub op: RoomAdminOp,
 }
 
-impl RoomAdminPayload {
-    pub fn room(&self) -> &Uuid {
-        match self {
-            RoomAdminPayload::AddMember { room, .. } => room,
-        }
-    }
+#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[serde(tag = "typ", rename_all = "snake_case")]
+pub enum RoomAdminOp {
+    AddMember {
+        permission: MemberPermission,
+        user: UserKey,
+    },
+    RemoveMember {
+        user: UserKey,
+    },
+    // TODO: RU
 }
 
 bitflags! {
@@ -497,4 +499,23 @@ mod tests {
         let got = serde_json::to_string(&text).unwrap();
         assert_eq!(got, raw);
     }
+
+    #[test]
+    fn room_admin_serde() {
+        let data = RoomAdminPayload {
+            room: Uuid::nil(),
+            op: RoomAdminOp::AddMember {
+                permission: MemberPermission::POST_CHAT,
+                user: UserKey([0x42; PUBLIC_KEY_LENGTH]),
+            },
+        };
+        let raw = serde_jcs::to_string(&data).unwrap();
+
+        assert_eq!(
+            raw,
+            r#"{"permission":1,"room":"00000000-0000-0000-0000-000000000000","typ":"add_member","user":"4242424242424242424242424242424242424242424242424242424242424242"}"#
+        );
+        let got = serde_json::from_str::<RoomAdminPayload>(&raw).unwrap();
+        assert_eq!(got, data);
+    }
 }